aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
================
Comment at: clang/include/clang/Basic/Attr.td:2134
+def SwiftBridge : Attr {
+ let Spellings = [GNU<"swift_bridge">];
+ let Args = [StringArgument<"SwiftType">];
----------------
compnerd wrote:
> aaron.ballman wrote:
> > Is it intentional that this is `swift_bridge` but we just added
> > `swift_bridged_typedef` (bridge vs bridged)? That seems like a bit of a
> > spelling gotcha, if it can be corrected.
> Yes, that is intentional. This has already shipped, so Im afraid that
> changing the spelling isn't really reasonable at this point. I agree that it
> is is a spelling gotcha, but fortunately, most of the uses of these are done
> through macros (e.g. `CF_REFINED_FOR_SWIFT`).
Okie dokie, that's what I figured.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87532/new/
https://reviews.llvm.org/D87532
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
