tra accepted this revision. tra added a comment. This revision is now accepted and ready to land.
Does this naming scheme the same as used for `.o` files? We may want to keep them in sync. Other than that, LGTM. ================ Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:909 + auto AddPostfix = [JA](auto &F) { + if (JA.getOffloadingDeviceKind() == Action::OFK_HIP) + F += (Twine("_") + JA.getOffloadingArch()).str(); ---------------- I think the same approach would make sense for CUDA, too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87791/new/ https://reviews.llvm.org/D87791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits