MaskRay added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:90
+ } else {
+ if (Output.isFilename())
+ F = Output.getFilename();
----------------
The output selection logic is untested.
================
Comment at: clang/test/Driver/opt-record.c:24
+// No pass-through: lto is disabled
+// RUN: %clang -target x86_64-linux-gnu -### -o FOO
-fdiagnostics-hotness-threshold=100 -fsave-optimization-record %s 2>&1 | not
FileCheck %s -check-prefix=CHECK-PASS
+
----------------
x86_64-linux-gnu can usually be simplied as x86_64.
There is no test without `-o FOO`.
Consider moving the RUN lines below, immediately above CHECK-PASS: lines
================
Comment at: clang/test/Driver/opt-record.c:56
+// CHECK-PASS: "--plugin-opt=opt-remarks-filename=FOO.opt.ld.yaml"
+// CHECK-PASS: "--plugin-opt=opt-remarks-passes=inline"
+// CHECK-PASS: "--plugin-opt=opt-remarks-format=yaml"
----------------
Add `-SAME` whenever appropriate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D85810/new/
https://reviews.llvm.org/D85810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
