usaxena95 marked an inline comment as done.
usaxena95 added inline comments.
================
Comment at: clang-tools-extra/clangd/quality/CompletionModel.cmake:13
+
+ set(output_dir ${CMAKE_BINARY_DIR}/generated/decision_forest)
+ set(header_file ${output_dir}/${filename}.h)
----------------
sammccall wrote:
> /generated/decision_forest seems redundant considering ${CMAKE_BINARY_DIR} is
> already the generated-files tree for the directory of the calling CMakeLists.
>
> Can't we just use ${CMAKE_BINARY_DIR} directly and avoid the
> DECISION_FOREST_OUTPUT_DIR variable?
Changed `CMAKE_BINARY_DIR` to `CMAKE_CURRENT_BINARY_DIR` and removed
/generated/decision_forest to avoid the `DECISION_FOREST_OUTPUT_DIR` variable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83814/new/
https://reviews.llvm.org/D83814
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
