martong abandoned this revision.
martong added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:694
// execution continues on a code whose behaviour is undefined.
assert(SuccessSt);
NewState = SuccessSt;
----------------
martong wrote:
> This is where we crashed before this fix.
`assert(SuccessSt);` should not ever fail. Seems like the logic is not flawed
in `negate` rather there is an issue in the underlying
`RangeConstraintManager`: the analyzer goes on with an unfeasible path.
See the post-commit comments here: https://reviews.llvm.org/D82445
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87785/new/
https://reviews.llvm.org/D87785
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
