jdoerfert added inline comments.
================ Comment at: openmp/libomptarget/src/interface.cpp:118 + __tgt_target_data_begin_mapper_loc(nullptr, device_id, arg_num, args_base, args, + arg_sizes, arg_types, nullptr); +} ---------------- why not pass arg_mappers ================ Comment at: openmp/libomptarget/src/interface.cpp:164 __tgt_target_data_begin_mapper(device_id, arg_num, args_base, args, arg_sizes, arg_types, arg_mappers); } ---------------- Please call the new version with a nullptr here. ================ Comment at: openmp/libomptarget/src/interface.cpp:202 + __tgt_target_data_end_mapper_loc(nullptr, device_id, arg_num, args_base, args, arg_sizes, + arg_types, nullptr); +} ---------------- Why is this passing nullptr in the end? ================ Comment at: openmp/libomptarget/src/interface.cpp:254 __tgt_target_data_end_mapper(device_id, arg_num, args_base, args, arg_sizes, arg_types, arg_mappers); } ---------------- use the new version ================ Comment at: openmp/libomptarget/src/interface.cpp:323 __tgt_target_data_update_mapper(device_id, arg_num, args_base, args, arg_sizes, arg_types, arg_mappers); } ---------------- use the new version ================ Comment at: openmp/libomptarget/src/interface.cpp:358 + return __tgt_target_mapper_loc(nullptr, device_id, host_ptr, arg_num, args_base, args, + arg_sizes, arg_types, nullptr); +} ---------------- why not pass arg_mappers ================ Comment at: openmp/libomptarget/src/interface.cpp:419 + arg_sizes, arg_types, arg_mappers); +} + ---------------- Where is the non-loc version? why not next to it? ================ Comment at: openmp/libomptarget/src/interface.cpp:480 return __tgt_target_teams_mapper(device_id, host_ptr, arg_num, args_base, args, arg_sizes, arg_types, arg_mappers, team_num, thread_limit); } ---------------- Please call the new version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87946/new/ https://reviews.llvm.org/D87946 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits