nemanjai added inline comments.

================
Comment at: clang/lib/Sema/SemaChecking.cpp:3165
 
+static bool isEltOfVectorTy(ASTContext &Context, CallExpr *Call, Sema &S,
+                            QualType VectorEltTy, QualType EltTy) {
----------------
I think this should actually take a vector type and a scalar type. Then check 
that the scalar type is the same as the element type of the vector. The way 
this is implemented, a more apt name would be something like `checkSameTypes()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83500/new/

https://reviews.llvm.org/D83500

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to