hubert.reinterpretcast added inline comments.
================
Comment at: clang/test/Driver/aix-ld.c:215
// CHECK-LD64-NO-DEFAULT-LIBS: {{.*}}clang{{(.exe)?}}" "-cc1" "-triple"
"powerpc64-ibm-aix7.1.0.0"
+// CHECK-LD64-NO-STD-LIB: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK-LD64-NO-DEFAULT-LIBS: "-isysroot" "[[SYSROOT:[^"]+]]"
----------------
Copy/paste error?
================
Comment at: clang/test/Driver/aix-ld.c:237
// CHECK-LD32-CXX-ARG-ORDER: {{.*}}clang{{.*}}" "-cc1" "-triple"
"powerpc-ibm-aix7.1.0.0"
+// CHECK-LD32-CXX-ARG-ORDERP: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]"
// CHECK-LD32-CXX-ARG-ORDER: "-isysroot" "[[SYSROOT:[^"]+]]"
----------------
Typo?
================
Comment at: clang/test/Driver/aix-ld.c:249
// CHECK-LD32-CXX-ARG-ORDER: "-lc++"
+// CHECK-LD32-CXX-ARG-ORDERP:
"[[RESOURCE_DIR]]/lib/aix/libclang_rt.builtins-powerpc.a"
// CHECK-LD32-CXX-ARG-ORDER: "-lc"
----------------
Typo?
================
Comment at: clang/test/Driver/aix-rtlib.c:3
+// RUN: %clang -target powerpc-ibm-aix -print-libgcc-file-name
-no-canonical-prefixes \
+// RUN: -resource-dir=%S/Inputs/resource_dir | FileCheck
-check-prefix=CHECK32 %s
+// RUN: %clang -target powerpc64-ibm-aix -print-libgcc-file-name
-no-canonical-prefixes \
----------------
Remove "hard" tab. Indent to line up the hyphens.
================
Comment at: clang/test/Driver/aix-rtlib.c:5
+// RUN: %clang -target powerpc64-ibm-aix -print-libgcc-file-name
-no-canonical-prefixes \
+// RUN: -resource-dir=%S/Inputs/resource_dir | FileCheck
-check-prefix=CHECK64 %s
+
----------------
Same. Plus remove extra spaces.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88182/new/
https://reviews.llvm.org/D88182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
