jyknight added a comment. I'm happy with this now, but please update the commit message to match the updated change.
================ Comment at: clang/include/clang/AST/ASTContext.h:2177-2179 /// This can be different than the ABI alignment in cases where it is - /// beneficial for performance to overalign a data type. + /// beneficial for performance or backwards compatibility preserving to + /// overalign a data type. ---------------- Rather than the phrase you added, I'd instead add a new sentence: "Note: despite the name, the preferred alignment is ABI-impacting, and not an optimization." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86790/new/ https://reviews.llvm.org/D86790 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
