nickdesaulniers accepted this revision. nickdesaulniers added a comment. In D88195#2293637 <https://reviews.llvm.org/D88195#2293637>, @jyknight wrote:
> In D88195#2293597 <https://reviews.llvm.org/D88195#2293597>, @nickdesaulniers > wrote: > >> In D88195#2293589 <https://reviews.llvm.org/D88195#2293589>, @void wrote: >> >>> Clarify commit message. >> >> Phabricator unfortunately won't amend the review description when the commit >> message is updated; you'll need to manually edit the description via phab's >> UI for other reviewers to observe the update. :( > > You can see the description separately, under the "Commits" tab, but yea. > Also, if you use `arc diff --verbatim` to upload the new review, it'll update > the review message at the same time. > > --verbatim > When creating a revision, try to use the working copy commit > message verbatim, without prompting to edit it. When updating a > revision, update some fields from the local commit message. TIL, thanks for that power up. Thanks for the fix, Bill! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88195/new/ https://reviews.llvm.org/D88195 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
