MaskRay added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1964 for (StringRef Candidate : CandidateBiarchTripleAliases) ScanLibDirForGCCTriple(TargetTriple, Args, LibDir, Candidate, /*NeedsBiarchSuffix=*/ true); ---------------- MaskRay wrote: > Its use of GCCDirExists is uninitialized. I suggest that you set GCCDirExists > and GCCCrossDirExists to be conservative. You may still GCCDirExists = GCCCrossDirExists = true here If they are set to false by CandidateLibDirs, you don't want them to suppress the detection for CandidateBiarchLibDirs. This probably suggests that the variables should not be member variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87901/new/ https://reviews.llvm.org/D87901 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits