jasonliu accepted this revision.
jasonliu added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1749-1750
- // Otherwise, allocate just the number of bytes required to store
- // the bitfield.
+ // Otherwise, allocate just the number of bytes required to store
+ // the bitfield.
} else {
----------------
nit: drive-by fix?
I think we should move this block of comments into the else block.
================
Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1768-1770
+ // Otherwise, bump the data size up to include the bitfield,
+ // including padding up to char alignment, and then remember how
+ // bits we didn't use.
----------------
nit: same as the above driver-by fix.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88260/new/
https://reviews.llvm.org/D88260
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
