arames marked 2 inline comments as done.
arames added inline comments.
================
Comment at: clang/test/Sema/fp16vec-sema.c:29
sv0 = hv0 >= hv1;
+ hv0, 1; // expected-warning 2 {{expression result unused}}
sv0 = hv0 || hv1; // expected-error{{logical expression with vector types
'half4' (vector of 4 '__fp16' values) and 'half4' is only supported in C++}}
----------------
fhahn wrote:
> nit: it might be slightly better to move it 2 lines further down, so all
> operators that assign the result are grouped together. Also, should we add
> `1, hv0` as well?
Moved.
I added `1, hv0` for completeness. It would hit the same path as the reverse.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88265/new/
https://reviews.llvm.org/D88265
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
