NoQ added a comment.

> Yup, that's pretty bad.

One slightly redeeming thing about this crash is that it's assertion-only. When 
built without assertions clang doesn't crash and this patch doesn't really 
change its behavior (adding transition to a null state is equivalent to adding 
no transitions at all). This means that the assertion did its job and notified 
us of the serious issue but simply removing the assertion doesn't bring *that* 
much benefit and we can probably afford to wait for a more solid fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86743/new/

https://reviews.llvm.org/D86743

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to