usaxena95 added inline comments.

================
Comment at: 
clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74
+  for (auto _ : State) {
+    srand(0);
+    State.PauseTiming();
----------------
adamcz wrote:
> Move this out of the loop. Right now we re-generate "random" dataset, but 
> it's always the same dataset ;-)
I added it inside the loop since there is only one state right now. But 
probably moving it out makes it more meaningful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88590/new/

https://reviews.llvm.org/D88590

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to