Xiangling_L added inline comments.
================
Comment at: clang/lib/Sema/SemaDecl.cpp:16447
+
+ bool AIXBitfieldViolation = false;
+ if (const BuiltinType *BTy = FieldTy.getTypePtr()->getAs<BuiltinType>()) {
----------------
sfertile wrote:
> Can this change can be split out into its own patch? If it can i would
> suggest doing so.
I was expecting our buildbot can pick up all bitfield related changes at one
time. Also if we split this out, that means we either need to wait for this
second part to land first or need to add more LIT to oversized long long to the
first part, which then needs to be removed whenever this second part land. It
seems we are complicating the patch. Can you give me your rationale about why
we want to split out this part?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87029/new/
https://reviews.llvm.org/D87029
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
