rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
lgtm ================ Comment at: test/SemaCXX/no-wchar.cpp:12 @@ +11,2 @@ +void foo1(wchar_t * t = L""); +// expected-warning@-1 {{conversion from string literal to 'wchar_t *' (aka 'unsigned short *') is deprecated}} ---------------- Can you add some negative tests like these: short *p1 = L""; // error int *p2 = L""; // error Even if they don't make it into IsStringLiteralToNonConstPointerConversion, it's nice to test around things a bit. http://reviews.llvm.org/D19056 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits