jasonliu added inline comments.
================
Comment at: lld/Common/TargetOptionsCommandFlags.cpp:17
+llvm::TargetOptions
+lld::initTargetOptionsFromCodeGenFlags(const llvm::Triple &TheTriple) {
+ return llvm::codegen::InitTargetOptionsFromCodeGenFlags(TheTriple);
----------------
MaskRay wrote:
> jasonliu wrote:
> > MaskRay wrote:
> > > Currently lld does not need Triple. Consider not changing the signature
> > > of `initTargetOptionsFromCodeGenFlags`.
> > This function acts like a forwarder for
> > llvm::codegen::InitTargetOptionsFromCodeGenFlags.
> > I think it still makes sense to change the signature in this case to
> > minimize the different variation of the function, as those variations cause
> > confusion to people.
> > I will change the name to match the LLVM style.
> If you want to change `InitTargetOptionsFromCodeGenFlags` in an incompatible
> way, you can by the way rename it to `initTarget*`.
>
> lld functions should always stick with the `camelCase` rule. If there is no
> meaningful triple, I'd prefer leave out the parameter.
Sorry, didn't realize lld has this `camelCase` rule.
I don't have a better naming for it, so I will just leave the function
signature untouched.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88737/new/
https://reviews.llvm.org/D88737
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
