amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land.
LGTM. Thanks for extending this functionality to Windows! ================ Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:15 +#include "llvm/Support/Windows/WindowsSupport.h" #include <atomic> #include <condition_variable> ---------------- I don't see a reason to include `<atomic>` here. ================ Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:77 + void WatcherThreadProc(HANDLE DirectoryHandle); + void NotifierThreadProc(bool WaitForInitialSync); }; ---------------- I like the name change from HandlerThread to NotifierThread. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https://reviews.llvm.org/D88666 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
