arphaman added inline comments.

================
Comment at: 
clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:222
 
-  const llvm::MemoryBuffer *getBufferPtr() const { return Buffer.get(); }
+  const char *getBufferPtr() const {
+    return Buffer ? nullptr : Buffer->getBufferStart();
----------------
Looking over the code this method doesn't seem necessary anymore. Can you get 
the buffer pointer in `createFile` down below, after 
`llvm::MemoryBuffer::getMemBuffer(*Contents, Entry->getName(), 
/*RequiresNullTerminator=*/false)` is constructed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89136/new/

https://reviews.llvm.org/D89136

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to