dyung added inline comments.
================ Comment at: clang/test/CodeGen/X86/avx-union.c:2 +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX +// RUN: %clang_cc1 -w -ffreestanding -triple x86_64-linux-gnu -target-feature +avx512f -emit-llvm -o %t %s || FileCheck < %t %s --check-prefix=CHECK, AVX512 +// This tests verifies that a union parameter should pass by a vector regitster whose first eightbyte is SSE and the other eightbytes are SSEUP. ---------------- These RUN lines have 2 issues, you are using "||" instead of "|" and each check prefix must have its own argument, so you need "--check-prefix=CHECK --check-prefix=AVX". ================ Comment at: clang/test/CodeGen/X86/avx-union.c:22 +union M512 m2; +// CHECK-LABEL: define dso_local void @test() +// CHECK: void @foo1(<4 x double> ---------------- When I fix the run lines above, I'm not getting "dso_local". Might want to double check that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78699/new/ https://reviews.llvm.org/D78699 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
