ASDenysPetrov added a comment.

@NoQ

> Can we collapse this function further towards this goal? Say, why not pump 
> every region unconditionally through castRegion()? Does dispatchCast() use 
> castRegion() internally - and if it does, why are there so many branches in 
> this function?

I've made some investigations. `castRegion()` does not use inside 
`dispatchCast()`, it belongs to `StoreManager`. Moving it to 
`SimpleSValBuilder` will be hard at least for now, since it is quite complex, 
but we can try. What do you think. Should I go further or we can apply this 
patch as is?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89055/new/

https://reviews.llvm.org/D89055

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to