jdenny added a comment.
Thanks for working on this. Sorry to take so long to review. Before I try to
digest the code, I have a few high-level questions.
Based on the test suite changes, `TARGET_PARAM` is disappearing from many
cases. Can you explain a bit how that supports overlapping and reordering?
Have you considered issue 2337 for the OpenMP spec and how your implementation
handles the ambiguous cases cited there?
================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7283
+ llvm::find(MotionModifiers, OMPC_MOTION_MODIFIER_present) !=
+ MotionModifiers.end())
Bits |= OMP_MAP_PRESENT;
----------------
Unrelated change?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86119/new/
https://reviews.llvm.org/D86119
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
