Anastasia added inline comments.
================ Comment at: clang/include/clang/Basic/OpenCLExtensions.def:16 // // If the extensions are to be enumerated without the supported OpenCL version, // define OPENCLEXT(ext) where ext is the name of the extension. ---------------- yaxunl wrote: > Can you add a comment here referring the spec about "Every extension which > affects the OpenCL language semantics, syntax or adds built-in functions to > the language must create a preprocessor #define that matches the extension > name string." and therefore only extensions "which affects the OpenCL > language semantics, syntax or adds built-in functions to the language" are > defined in this file. Thanks. Good idea! I also suggest we add clarifications regarding pragmas, that those are to be added only when the compiler needs to change the compilation flow i.e. if there is a difference in the language semantic from what is defined in a standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89372/new/ https://reviews.llvm.org/D89372 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
