yaxunl marked 4 inline comments as done.
yaxunl added inline comments.
================
Comment at: clang/include/clang/Basic/Diagnostic.h:1065
+///
+class StreamableDiagnosticBase {
+public:
----------------
rjmccall wrote:
> I think I would prefer `StreamingDiagnostic` as the class name here.
renamed
================
Comment at: clang/include/clang/Basic/PartialDiagnostic.h:66
+ return *this;
+ }
+
----------------
rjmccall wrote:
> Why are these template operators necessary? The LHS of the `<<` should
> convert to a base reference type just fine.
There are lots of usage patterns expecting the derived class after streaming,
e.g.
```
void foo(PartialDiagnostic& PD);
foo(PD << X << Y);
```
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84362/new/
https://reviews.llvm.org/D84362
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
