fhahn added inline comments.
================
Comment at: clang/lib/Parse/ParsePragma.cpp:1096
static_cast<PragmaLoopHintInfo *>(Tok.getAnnotationValue());
-
IdentifierInfo *PragmaNameInfo = Info->PragmaName.getIdentifierInfo();
----------------
nit: unrelated change?
================
Comment at: clang/lib/Sema/SemaStmtAttr.cpp:144
+ assert(ValueExpr && "Attribute must have a valid value expression.");
+ if (S.CheckLoopHintExpr(ValueExpr, St->getBeginLoc()))
+ return nullptr;
----------------
Is there a way to only accept `fixed_width/scalable` for targets that support
it? Not sure if we have enough information here, but we might be able to reject
it eg per target basis or something
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89031/new/
https://reviews.llvm.org/D89031
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
