Xiangling_L marked an inline comment as done.
Xiangling_L added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4924
+ if (RawTriple.isOSAIX())
+ if (Arg *A = Args.getLastArg(options::OPT_G)) {
----------------
jasonliu wrote:
> Question: When do we query `RawTriple`, and when we should query `Triple`?
`RawTriple` in this function means the triple you passed in or the default one.
`Triple` in this function means `a ToolChain's effective triple`.
An effective triple is:
> the Clang triple to use for this target, which may take into account the
> command line arguments. For example, on Darwin the -mmacosx-version-min=
> command line argument (which
> sets the deployment target) determines the version in the triple passed to
> Clang.
So I feel, if there is no special condition we need to consider, we just use
`RawTriple`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89897/new/
https://reviews.llvm.org/D89897
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
