[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev created this revision.
kbobyrev added reviewers: kadircet, sammccall.
Herald added subscribers: cfe-commits, usaxena95, arphaman.
Herald added a project: clang.
kbobyrev requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.

Fixes: https://github.com/clangd/clangd/issues/571


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90116

Files:
  clang-tools-extra/clangd/CodeComplete.h
  clang-tools-extra/clangd/Diagnostics.cpp


Index: clang-tools-extra/clangd/Diagnostics.cpp
===================================================================
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -545,7 +545,7 @@
 
   OS << R;
   if (R.size() != Code.size())
-    OS << "…";
+    OS << "\u2026"; // Unicode Horizontal Ellipsis.
 }
 
 /// Fills \p D with all information, except the location-related bits.
Index: clang-tools-extra/clangd/CodeComplete.h
===================================================================
--- clang-tools-extra/clangd/CodeComplete.h
+++ clang-tools-extra/clangd/CodeComplete.h
@@ -86,7 +86,7 @@
   /// A visual indicator to prepend to the completion label to indicate whether
   /// completion result would trigger an #include insertion or not.
   struct IncludeInsertionIndicator {
-    std::string Insert = "•";
+    std::string Insert = "\u2022"; // Unicode Bullet.
     std::string NoInsert = " ";
   } IncludeIndicator;
 



Index: clang-tools-extra/clangd/Diagnostics.cpp
===================================================================
--- clang-tools-extra/clangd/Diagnostics.cpp
+++ clang-tools-extra/clangd/Diagnostics.cpp
@@ -545,7 +545,7 @@
 
   OS << R;
   if (R.size() != Code.size())
-    OS << "…";
+    OS << "\u2026"; // Unicode Horizontal Ellipsis.
 }
 
 /// Fills \p D with all information, except the location-related bits.
Index: clang-tools-extra/clangd/CodeComplete.h
===================================================================
--- clang-tools-extra/clangd/CodeComplete.h
+++ clang-tools-extra/clangd/CodeComplete.h
@@ -86,7 +86,7 @@
   /// A visual indicator to prepend to the completion label to indicate whether
   /// completion result would trigger an #include insertion or not.
   struct IncludeInsertionIndicator {
-    std::string Insert = "•";
+    std::string Insert = "\u2022"; // Unicode Bullet.
     std::string NoInsert = " ";
   } IncludeIndicator;
 

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits