EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

This part LGTM. Sorry about the delay.


================
Comment at: CMakeLists.txt:187
@@ +186,3 @@
+if (NOT LIBCXXABI_LIBCXX_LIBRARY_PATH)
+  set(LIBCXXABI_LIBCXX_LIBRARY_PATH "${LIBCXXABI_LIBRARY_DIR}" CACHE PATH
+      "The path to libc++ library.")
----------------
This variable should still probably be re-set even if it's given on the command 
line. By doing that you update the type and help text for the variable in the 
cache.


http://reviews.llvm.org/D16545



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to