sammccall created this revision. sammccall added a reviewer: eduucaldas. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision.
I think this was just an oversight. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90541 Files: clang/lib/Tooling/Syntax/Tree.cpp Index: clang/lib/Tooling/Syntax/Tree.cpp =================================================================== --- clang/lib/Tooling/Syntax/Tree.cpp +++ clang/lib/Tooling/Syntax/Tree.cpp @@ -305,6 +305,7 @@ case syntax::NodeKind::NestedNameSpecifier: case syntax::NodeKind::CallArguments: case syntax::NodeKind::ParameterDeclarationList: + case syntax::NodeKind::DeclaratorList: return true; default: return false; @@ -405,6 +406,7 @@ return clang::tok::coloncolon; case NodeKind::CallArguments: case NodeKind::ParameterDeclarationList: + case NodeKind::DeclaratorList: return clang::tok::comma; default: llvm_unreachable("This is not a subclass of List, thus " @@ -418,6 +420,7 @@ return TerminationKind::Terminated; case NodeKind::CallArguments: case NodeKind::ParameterDeclarationList: + case NodeKind::DeclaratorList: return TerminationKind::Separated; default: llvm_unreachable("This is not a subclass of List, thus " @@ -433,6 +436,8 @@ return true; case NodeKind::ParameterDeclarationList: return true; + case NodeKind::DeclaratorList: + return true; default: llvm_unreachable("This is not a subclass of List, thus canBeEmpty() " "cannot be called");
Index: clang/lib/Tooling/Syntax/Tree.cpp =================================================================== --- clang/lib/Tooling/Syntax/Tree.cpp +++ clang/lib/Tooling/Syntax/Tree.cpp @@ -305,6 +305,7 @@ case syntax::NodeKind::NestedNameSpecifier: case syntax::NodeKind::CallArguments: case syntax::NodeKind::ParameterDeclarationList: + case syntax::NodeKind::DeclaratorList: return true; default: return false; @@ -405,6 +406,7 @@ return clang::tok::coloncolon; case NodeKind::CallArguments: case NodeKind::ParameterDeclarationList: + case NodeKind::DeclaratorList: return clang::tok::comma; default: llvm_unreachable("This is not a subclass of List, thus " @@ -418,6 +420,7 @@ return TerminationKind::Terminated; case NodeKind::CallArguments: case NodeKind::ParameterDeclarationList: + case NodeKind::DeclaratorList: return TerminationKind::Separated; default: llvm_unreachable("This is not a subclass of List, thus " @@ -433,6 +436,8 @@ return true; case NodeKind::ParameterDeclarationList: return true; + case NodeKind::DeclaratorList: + return true; default: llvm_unreachable("This is not a subclass of List, thus canBeEmpty() " "cannot be called");
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits