rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land.
Thanks, this basically looks correct to me, aside from some formatting details. Do you want me to apply those fixes and land this for you? I see that was done for your last patch, but it's best to ask first. ================ Comment at: clang/lib/CodeGen/CodeGenModule.cpp:6153-6155 // For C++ class pointees, we don't know whether we're pointing at a // base or a complete object, so we generally need to use the // non-virtual alignment. ---------------- It's pretty uncommon to see comment blocks between the closing if curly and the next else if. Please move this comment inside the relevant else-if block. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90630/new/ https://reviews.llvm.org/D90630 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
