ArcsinX added inline comments.
================
Comment at: clang-tools-extra/clangd/test/remote-index/pipeline_helper.py:43
args.index_file, args.project_root
- ],
+ ] + args.server_arg,
stderr=subprocess.PIPE)
----------------
this breaks `remote-index/pipeline.test` test for me:
```
TypeError: can only concatenate list (not "NoneType") to list
```
================
Comment at: clang-tools-extra/clangd/test/remote-index/public-log.test:5
+# RUN: %python %S/pipeline_helper.py --input-file-name=%s
--server-arg=--log=verbose --server-log=%t.log --project-root=%S
--index-file=%t.idx > /dev/null
+# RUN: FileCheck --check-prefixes=LOG,LOG-PUBLIC %s < %t.public.log
+# RUN: FileCheck --check-prefixes=LOG,LOG-ALL %s < %t.log
----------------
Maybe we can use `--input-file` option of FileCheck instead of `<` (the same
for the next line)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90654/new/
https://reviews.llvm.org/D90654
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
