thakis added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3382 } + if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) + CmdArgs.push_back("-fprebuilt-implicit-modules"); ---------------- You need to use a fno_ flag as 2nd param if you want to use hasFlag, the default value is the third param: http://45.33.8.238/win/27354/step_4.txt ```` ../../clang/lib/Driver/ToolChains/Clang.cpp(3382,63): error: conversion from 'bool' to 'llvm::opt::OptSpecifier' is ambiguous if (Args.hasFlag(options::OPT_fprebuilt_implicit_modules, false)) ^~~~~ ../../llvm/include\llvm/Option/OptSpecifier.h(24,16): note: candidate constructor /*implicit*/ OptSpecifier(unsigned ID) : ID(ID) {} ^ ../../llvm/include\llvm/Option/OptSpecifier.h(25,16): note: candidate constructor /*implicit*/ OptSpecifier(const Option *Opt); ^ ../../llvm/include\llvm/Option/ArgList.h(295,47): note: passing argument to parameter 'Neg' here bool hasFlag(OptSpecifier Pos, OptSpecifier Neg, bool Default=true) const; ^ 1 error generated. ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68997/new/ https://reviews.llvm.org/D68997 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits