[PATCH] D90849: [dllexport] Avoid multiple codegen assert for explicitly defaulted methods in explicit instantiation definitions (PR47683)

[Hans Wennborg via Phabricator via cfe-commits]

hans marked 3 inline comments as done.
hans added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5898
         // encountered.
       } else if (!MD->isTrivial() || MD->isExplicitlyDefaulted() ||
                  MD->isCopyAssignmentOperator() ||
----------------
rnk wrote:
> Part of me wants to handle explicitly defaulted things separately from 
> implicit special members, so we don't have to check for explicitly 
> defaulted-ness twice.
Thanks, that makes it a bit nicer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90849/new/

https://reviews.llvm.org/D90849

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits