lxfind added inline comments.
================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:475
+ if (!AwaitSuspend)
+ return Calls;
if (!AwaitSuspend->getType()->isDependentType()) {
----------------
bruno wrote:
> In case `AwaitSuspend` is null, is there any need to set `Calls.IsInvalid` as
> well?
Thanks for the catch.
================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:490
+ // ExprWithCleanups is wrapped within maybeTailCall() prior to the resume
+ // call.
Calls.Results[ACT::ACT_Suspend] = TailCallSuspend;
----------------
bruno wrote:
> Is there already a test covering this tailcall case? It'd be nice to have one
Yes both of the symmetric-transfer tests are covering this case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90990/new/
https://reviews.llvm.org/D90990
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
