jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/include/clang/Basic/DiagnosticSerializationKinds.td:20
"malformed block record in PCH file: '%0'">, DefaultFatal;
def err_fe_pch_file_modified : Error<
+ "file '%0' has been modified since the "
----------------
dexonsmith wrote:
> jansvoboda11 wrote:
> > I'm a bit confused by the fact that a diagnostic with `pch_file` in its
> > name might output `module file` or `AST file` as well.
> >
> > This file already contains a couple diagnostics that use a similar
> > `%select` and have `module` in their name (e.g.
> > `err_module_file_out_of_date`). Would it make sense to unify the
> > terminology here?
> Yeah, I wasn't sure what to do about that. `module` is also wrong. I ended up
> choosing `pch` just since the diagnostic was in a group of `pch` diagnostics.
>
> IMO, the best name for all of these is `ast` since that's the most generic
> term. I could rename the others to `ast` in a prep commit and then update
> this patch to use `ast` as well. WDYT?
Sounds good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91367/new/
https://reviews.llvm.org/D91367
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
