Re: [PATCH] D19278: [scan-build] fix logic error warnings emitted on clang code base

[John McCall via cfe-commits]

rjmccall added inline comments.

================
Comment at: lib/Sema/SemaOverload.cpp:9191
@@ -9189,1 +9190,3 @@
+               ToTy->isLValueReferenceType() &&
+               !FromExpr->isLValue() &&
                ToTy.getNonReferenceType().getCanonicalType() ==
----------------
Interleaving these conditions looks strange.  Please group the FromExpr-related 
checks next to each other.

Otherwise LGTM.


http://reviews.llvm.org/D19278



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits