arsenm added inline comments.

================
Comment at: lld/MachO/SymbolTable.cpp:137
     // error message.
-    if (auto *defined = dyn_cast<Defined>(s))
+    if (dyn_cast<Defined>(s))
       error("found defined symbol with illegal name " + DSOHandle::name);
----------------
Should use isa


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91519/new/

https://reviews.llvm.org/D91519

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D91519: [A... Gabriel Hjort Ã…kerlund via Phabricator via cfe-commits
    • [PATCH] D9151... Matt Arsenault via Phabricator via cfe-commits
    • [PATCH] D9151... Gabriel Hjort Ã…kerlund via Phabricator via cfe-commits
    • [PATCH] D9151... David Stenberg via Phabricator via cfe-commits

Reply via email to