hokein added a comment. In D84637#2345353 <https://reviews.llvm.org/D84637#2345353>, @rsmith wrote:
> There are a couple of cases where you're returning `EvalStmtResult` from a > function with a `bool` return type, that I'd like to see fixed before this > lands. > > All the other comments are directed towards producing more precise behavior > when evaluating a function containing errors / value-dependent constructs. I > don't think there's any need to block fixing the crasher here on improving > the diagnostics, so I'm happy if you ignore these and commit as-is (other > than fixing the return type issue), but I think we'll want to look at these > diagnostic improvements at some point. thanks for the useful comments, I think I have addressed most of them and added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84637/new/ https://reviews.llvm.org/D84637 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
