ldionne added a comment.

I think this looks good. I must admit I'm a bit worried about any unintended 
consequences this might have or breakage this might cause in cases where we'd 
switch from linking against the SDK libc++.dylib to the toolchain one. This 
would only impact the toolchain released by LLVM, not Apple's, though, since 
Apple's toolchain doesn't contain the dylib in `<clang>/../lib`.

I think this would merit a Clang release note.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D45639/new/

https://reviews.llvm.org/D45639

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to