sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land.
Thanks! ================ Comment at: clang-tools-extra/clangd/README.md:26 +- Create a build directory, for example at `$LLVM_ROOT/build`. +- Inside the build directory run: `cmake $LLVM_ROOT/llvm/ + -DCMAKE_BUILD_TYPE=RELEASE -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra"`. ---------------- this will work, though won't it use make by default with no parallelism? If we're recommending more flags, i'd suggest -DLLVM_ENABLE_ASSERTS=On, and -G Ninja... ================ Comment at: clang-tools-extra/clangd/README.md:27 +- Inside the build directory run: `cmake $LLVM_ROOT/llvm/ + -DCMAKE_BUILD_TYPE=RELEASE -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra"`. + ---------------- nit: traditionally Release rather than RELEASE (though IDK if it matters) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91186/new/ https://reviews.llvm.org/D91186 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
