ckennelly added inline comments.

================
Comment at: 
clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:65
 
+void fview() {
+  std::string_view a = "";
----------------
aaron.ballman wrote:
> Can you also add tests for `wstring_view`?
> 
> Also, perhaps one for `std::string_view foo{};` (to remove the spurious `{}`)
Done for `wstring_view`

re `std::string_view foo{}`, it looks like we don't even match `std::string{}`, 
https://godbolt.org/z/zaafrb


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91009/new/

https://reviews.llvm.org/D91009

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to