wmi accepted this revision.
wmi added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:978-982
Opts.DebugInfoForProfiling = Args.hasFlag(
OPT_fdebug_info_for_profiling, OPT_fno_debug_info_for_profiling, false);
+ Opts.PseudoProbeForProfiling =
+ Args.hasFlag(OPT_fpseudo_probe_for_profiling,
+ OPT_fno_pseudo_probe_for_profiling, false);
----------------
hoy wrote:
> wmi wrote:
> > Should it emit an error if DebugInfoForProfiling and
> > PseudoProbeForProfiling are enabled at the same time? I see that from the
> > other patch related with pseudoprobe discriminator, these two flags are
> > incompatible.
> Yes, we should. It's done in D91756 passbuilder.h :
> https://reviews.llvm.org/D91756#change-Bsibk2p32T1c for both `clang` and
> `opt`.
>
Ok, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D86502/new/
https://reviews.llvm.org/D86502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
