njames93 added a comment.

While I'm a fan of this change, I think this is the wrong way to do it. Leave 
the check the same, but build the regex in the pp callback constructor. That 
should only get called once for the lifetime of the check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91908/new/

https://reviews.llvm.org/D91908

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to