njames93 added a comment.

Just one last small nit.

// You can ignore this, nothing to do with this patch.
All these changes in the documentation tell me we should probably restructure 
the documentation for this check.
Right now we have NxM lines of documentation for each combination of style 
kind(N) and style option(M). 
This could probably be changed so we could describe each style option at the 
top of the documentation (`<StyleKind>Case`, `<StyleKind> Prefix`,  ...)
Then we could describe each StyleKind afterwards.

  .. option:: ClassCase, option::ClassPrefix...
  
  Transforms class names
  .. code-block:: c++
  
      class <Ident> {
      };
  
  .. option:: FunctionCase, option::FunctionPrefix...
  
  Transforms class names
  .. code-block:: c++
  
      void <Ident>(int Param0);



================
Comment at: 
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:149
+    StyleString.append("IgnoredRegexp");
+    std::string IgnoredRegexpStr = Options.get((StyleString).str(), "");
+    StyleString.resize(StyleSize);
----------------
Dont need to use `str()` here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90282/new/

https://reviews.llvm.org/D90282

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to