kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
Thanks!
================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:79
auto IncomingLevel2 = incomingCalls(IncomingLevel1[0].from, Index.get());
- EXPECT_THAT(IncomingLevel2, UnorderedElementsAre(
- AllOf(From(WithName("caller2")),
- FromRanges(Source.range("Caller1A"),
- Source.range("Caller1B"))),
- AllOf(From(WithName("caller3")),
-
FromRanges(Source.range("Caller1C")))));
+ EXPECT_THAT(IncomingLevel2,
+ ElementsAre(AllOf(From(WithName("caller2")),
----------------
let's also change these from EXPECT_ to ASSERT_. As we are dereferencing
elements in the following calls. Same in other places too.
================
Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:92
auto IncomingLevel4 = incomingCalls(IncomingLevel3[0].from, Index.get());
EXPECT_THAT(IncomingLevel4, ElementsAre());
}
----------------
s/ElementsAre()/IsEmpty()/
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92009/new/
https://reviews.llvm.org/D92009
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
