kbobyrev updated this revision to Diff 307317.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Resolve most actionable comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91952/new/
https://reviews.llvm.org/D91952
Files:
clang-tools-extra/clangd/refactor/Rename.cpp
clang-tools-extra/clangd/unittests/RenameTests.cpp
Index: clang-tools-extra/clangd/unittests/RenameTests.cpp
===================================================================
--- clang-tools-extra/clangd/unittests/RenameTests.cpp
+++ clang-tools-extra/clangd/unittests/RenameTests.cpp
@@ -540,6 +540,76 @@
}
)cpp",
+ // Fields in classes & partial and full specialiations.
+ R"cpp(
+ template<typename T>
+ struct Foo {
+ T [[Vari^able]] = 42;
+ };
+
+ void foo() {
+ Foo<int> f;
+ f.[[Varia^ble]] = 9000;
+ }
+ )cpp",
+ R"cpp(
+ template<typename T, typename U>
+ struct Foo {
+ T Variable[42];
+ U Another;
+
+ void bar() {}
+ };
+
+ template<typename T>
+ struct Foo<T, bool> {
+ T [[Var^iable]];
+ void bar() { ++[[Var^iable]]; }
+ };
+
+ void foo() {
+ Foo<unsigned, bool> f;
+ f.[[Var^iable]] = 9000;
+ }
+ )cpp",
+ R"cpp(
+ template<typename T, typename U>
+ struct Foo {
+ T Variable[42];
+ U Another;
+
+ void bar() {}
+ };
+
+ template<typename T>
+ struct Foo<T, bool> {
+ T Variable;
+ void bar() { ++Variable; }
+ };
+
+ template<>
+ struct Foo<unsigned, bool> {
+ unsigned [[Var^iable]];
+ void bar() { ++[[Var^iable]]; }
+ };
+
+ void foo() {
+ Foo<unsigned, bool> f;
+ f.[[Var^iable]] = 9000;
+ }
+ )cpp",
+ R"cpp(
+ struct Foo {
+ static int [[Var^iable]];
+ };
+
+ int Foo::[[Var^iable]] = 42;
+
+ void foo() {
+ int LocalInt = Foo::[[Var^iable]];
+ }
+ )cpp",
+
// Template parameters.
R"cpp(
template <typename [[^T]]>
Index: clang-tools-extra/clangd/refactor/Rename.cpp
===================================================================
--- clang-tools-extra/clangd/refactor/Rename.cpp
+++ clang-tools-extra/clangd/refactor/Rename.cpp
@@ -119,11 +119,28 @@
// declaration.
while (Method->isVirtual() && Method->size_overridden_methods())
Method = *Method->overridden_methods().begin();
- return dyn_cast<NamedDecl>(Method->getCanonicalDecl());
+ return Method->getCanonicalDecl();
}
if (const auto *Function = dyn_cast<FunctionDecl>(D))
if (const FunctionTemplateDecl *Template = Function->getPrimaryTemplate())
return canonicalRenameDecl(Template);
+ if (const auto *Field = dyn_cast<FieldDecl>(D)) {
+ // This is a hacky way to do something like
+ // CXXMethodDecl::getInstantiatedFromMemberFunction for the field because
+ // Clang AST does not store relevant information about the field that is
+ // instantiated.
+ const auto *FieldParent = dyn_cast<CXXRecordDecl>(Field->getParent())
+ ->getTemplateInstantiationPattern();
+ if (!FieldParent)
+ return Field->getCanonicalDecl();
+ // Field is not instantiation.
+ if (!FieldParent || Field->getParent() == FieldParent)
+ return Field->getCanonicalDecl();
+ for (const FieldDecl *Candidate : FieldParent->fields())
+ if (Field->getFieldIndex() == Candidate->getFieldIndex())
+ return Candidate->getCanonicalDecl();
+ llvm_unreachable("FieldParent should have field with same index as Field.");
+ }
return dyn_cast<NamedDecl>(D->getCanonicalDecl());
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
