teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
You think it's worth it to have a test for a user-specified deduction guide? I
think this is missing an 'explicit' deduction guide test, so maybe we could
test both things in a single additional test case.
Also, IIUC we ignore the IsCopyDeductionCandidate bit when importing and that
seems like a potential bug to me (the value is apparently used for some
overload resolution logic)?
Beside those two things this looks good to me.
================
Comment at: clang/lib/AST/ASTImporter.cpp:3332
+ // Common code to import an explicit specifier of different kind of
funcitons.
+ auto ImportExplicitExpr = [this, &Err](auto *Fun) -> ExpectedExpr {
----------------
typo "funcitons"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92109/new/
https://reviews.llvm.org/D92109
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
