njames93 added inline comments.
================ Comment at: clang-tools-extra/clangd/TidyProvider.cpp:113 + OptionStack.push_back(std::move(*Config)); + if (!OptionStack.back().InheritParentConfig) + break; ---------------- njames93 wrote: > sammccall wrote: > > njames93 wrote: > > > This will result in incorrect behaviour if a config specifies > > > `InheritParentConfig` as `false` > > Whoops, thanks! > > (Why is this optional<bool> rather than bool?) > I'm honestly not sure. Personally I don't think it should belong in > ClangTidyOptions. Its only used when reading configuration from files(or > command line). Maybe I'll rustle something up for that. What do you think about this approach? D92199 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92133/new/ https://reviews.llvm.org/D92133 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
