kadircet added a comment.

Haven't checked the details but is there a specific reason for implementing a 
custom protocol rather than making use of `NotifyOnStateChange` 
(https://grpc.github.io/grpc/cpp/classgrpc_1_1_channel_interface.html) or even 
`WaitForStateChange` if we really want to block the channel creation ?

Also if there's a need to make this an RPC request, there's the default 
`HealthCheck` request we can send, as described in 
https://github.com/grpc/grpc/blob/master/doc/health-checking.md. This is 
already enabled for remote-index-server in 
https://github.com/llvm/llvm-project/blob/master/clang-tools-extra/clangd/index/remote/server/Server.cpp#L310,
 but I suppose registering a callback for statechange and logging that should 
be enough for a "debugging" use case (not sure what the motivation currently 
is).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92198/new/

https://reviews.llvm.org/D92198

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to